Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(test) O3-2943: E2E test for Immunizations workflow #2148

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Muta-Jonathan
Copy link
Member

@Muta-Jonathan Muta-Jonathan commented Dec 11, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR introduces changes that edits E2E test for a recorded immunization

Screenrecord

Screen.Recording.2024-12-17.at.12.14.19.PM.mov

Related Issue

https://openmrs.atlassian.net/jira/software/c/projects/O3/issues/O3-2943

@Muta-Jonathan Muta-Jonathan changed the title O3-2943: Add e2e test for editing immunization recording workflow O3-2943: Add e2e test for editing a recorded immunization workflow Dec 11, 2024
@Muta-Jonathan Muta-Jonathan requested a review from kdaud December 11, 2024 17:50
@Muta-Jonathan
Copy link
Member Author

@kdaud
Copy link
Member

kdaud commented Dec 17, 2024

@Muta-Jonathan could you fix the failing build at https://github.com/openmrs/openmrs-esm-patient-chart/actions/runs/12283806300/job/34334997423?pr=2148?

@Muta-Jonathan
Copy link
Member Author

cc @kdaud

@NethmiRodrigo NethmiRodrigo changed the title O3-2943: Add e2e test for editing a recorded immunization workflow (test) O3-2943: Add e2e test for editing a recorded immunization workflow Dec 17, 2024
Copy link
Member

@kdaud kdaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Muta-Jonathan. The PR looks good overall. I left one comment to address.

  • Can you add the ticket URL and also update the PR title?

e2e/specs/immunizations.spec.ts Outdated Show resolved Hide resolved
@Muta-Jonathan
Copy link
Member Author

Thanks @Muta-Jonathan. The PR looks good overall. I left one comment to address.

  • Can you add the ticket URL and also update the PR title?

@kdaud also this seems resolved by @NethmiRodrigo

@kdaud
Copy link
Member

kdaud commented Dec 18, 2024

@Muta-Jonathan could you take a look at the PR title?

@Muta-Jonathan Muta-Jonathan changed the title (test) O3-2943: Add e2e test for editing a recorded immunization workflow (test) O3-2943: E2E test for Immunizations workflow Dec 18, 2024
@Muta-Jonathan Muta-Jonathan requested a review from kdaud December 18, 2024 09:10

await test.step('And I change the immunization Dose number within series to `2`', async () => {
await page.getByRole('spinbutton', { name: /dose number within series/i }).clear();
await page.getByRole('spinbutton', { name: /dose number within series/i }).fill('2');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the corresponding test in the validation step.

await page.getByRole('spinbutton', { name: /dose number within series/i }).clear();
await page.getByRole('spinbutton', { name: /dose number within series/i }).fill('2');
});

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also modify the vaccination date?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants